• Emily Stark's avatar
    Simplified domain: Further kill the edit bump · 5b3e9042
    Emily Stark authored
    The previous CL in this chain reveals trivial subdomain and scheme
    when the URL is unelided on hover. This CL adds a hover animation to
    the omnibox even before the user interacts with the page (in the
    hide-on-interaction field trial). This allows the user to hover over
    the omnibox to bring back the scheme and trivial subdomain even before
    the URL has been elided to the simplified domain, thereby minimizing
    the potential of having an edit bump before interacting the page as
    well as after.
    
    The main change is that we need to create the hover animation
    earlier. Previously, we were creating it once the user interacts with
    the page; now we create it on page load. Each elide/unelide operation
    decides whether to use the full URL, partially elided URL (just scheme
    and trivial subdomain hidden), or simplified domain based on whether
    the user has interacted with the page yet or not.
    
    Bug: 1101486
    Change-Id: Id747929df56becadc34f0cb7a581494f4d90df5f
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291310
    Commit-Queue: Emily Stark <estark@chromium.org>
    Reviewed-by: default avatarTommy Li <tommycli@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#788837}
    5b3e9042
omnibox_view_views.h 26.7 KB