• Manu Cornet's avatar
    CrOS Shelf: Mark manual pin/unpin changes as user-triggered · 5b65a4f3
    Manu Cornet authored
    This particular change should not cause any behaviour change.
    
    This new distinction will be used for at least two purposes in the
    near future:
    
    1) provide accessibility feedback (alert) when an item has been
       pinned to, or unpinned from, the shelf
    
    2) provide visual feedback when an item has been pinned to the
       "scrollable" shelf (for instance scroll the scroll view to have
       the new item within the viewport).
    
    Neither of these interactions should happen when the pinning/unpinning
    is not a result of a user-initiated action, such as in callbacks to
    sync events.
    
    Bug: 1012772, 1010697
    Change-Id: Ib581aa05841826b78a7ba8cfe5d2b0a52f367810
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925439
    Commit-Queue: Manu Cornet <manucornet@chromium.org>
    Reviewed-by: default avatarTrent Apted <tapted@chromium.org>
    Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#717748}
    5b65a4f3
shelf_model.h 7.14 KB