• Andrew Grieve's avatar
    Add support for proguard and asset/lib expectation diffs · 5b72f4a3
    Andrew Grieve authored
    * Refactors more common logic for the three expectation file types
      into diff_utils.py
    * Changes sort order for proguard expectations so that they diff better
    * Output "actual_data" rather than .stamp files for expectation targets
    * Stop writing out .proguard_configs for all proguard runs
      * I don't think these files have been referenced for a long time, and
        the expectations file largely serves their purpose in a more
        discoverable way.
    * Don't define validate_expectations GN group unless it will
      have deps (to prevent thinking your GN args are correct when
      they are not).
    
    Bug: 1064151
    Change-Id: I5394471e7defd2c2f7e2f2173097a11d830cde65
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314265Reviewed-by: default avatarMohamed Heikal <mheikal@chromium.org>
    Commit-Queue: Andrew Grieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#791342}
    5b72f4a3
proguard.py 17.3 KB