• Mikel Astiz's avatar
    Remove default constructor for SessionID · 5b74b87c
    Mikel Astiz authored
    It was recently deprecated in favor of the less subtle
    SessionID::NewUnique(), with the same implementation. This patch
    removes the deprecated API which includes the aforementioned default
    constructor as well as SessionID::set_id().
    
    Most calling sites have been migrated in recent CLs and the remaining
    ones are now surfaced, both intentional and accidental.
    
    The plan for follow-up patches will consider:
    1. Reintroducing the default constructor, but with
       SessionID::InvalidValue() as the default.
    2. Moving SessionID::NewUnique() to a factory method in a newly
       introduced KeyedService for this purpose.
    
    Bug: 823798
    Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    Change-Id: I3abbc9b5a1497c11a99c9f80c6b2eadb7b7c6df8
    Reviewed-on: https://chromium-review.googlesource.com/995899
    Commit-Queue: Mikel Astiz <mastiz@chromium.org>
    Reviewed-by: default avatarYaron Friedman <yfriedman@chromium.org>
    Reviewed-by: default avatarrajendrant <rajendrant@chromium.org>
    Reviewed-by: default avatarRohit Rao <rohitrao@chromium.org>
    Reviewed-by: default avatarScott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#550127}
    5b74b87c
tab_id_provider.cc 4.43 KB