-
brettw authored
Revert of Make mojo/services pass in "gn check" (patchset #3 id:40001 of https://codereview.chromium.org/581273003/) Reason for revert: Broke component build Original issue's description: > Make mojo/services pass in "gn check" > > This mostly just adds the missing dependency identified by the checker. > > In some cases I looked at the target and added public_deps that I thought were appropriate given the nature of the target. > > This renames the generated mojo action names to be foo__generator instead of foo_generator since it is not clear from the current name that it is an internally-generated target and I kept trying to use it. The double-underscore matches the Android generated targets. > > In a few cases I changed ordering (sources come before deps in GN style) but I didn't want to make the changes difficult to diff so didn't do it for most cases. > > R=darin@chromium.org > > Committed: https://crrev.com/e2311613971cf63c66b60ebea38b4592b8520b8f > Cr-Commit-Position: refs/heads/master@{#295797} TBR=davemoore@chromium.org,darin@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/583423002 Cr-Commit-Position: refs/heads/master@{#295801}
5bbc0453