• Asanka Herath's avatar
    Remove usage of SEE_MASK_FLAG_NO_UI from ui::base::win · 5bcdfd9c
    Asanka Herath authored
    The flag was originally added to suppress messages from popping up if
    the Windows shell failed to open the specified item.
    
    Specifically, the ui::base::win::OpenAnyViaShell() function handles the
    case where ShellExecute() returns ERROR_NO_ASSOCIATION when invoked with
    the "open" verb by attempting to invoke the same using the "openas"
    verb. Thus an intervening error message would not have been useful.
    However the SEE_MASK_FLAG_NO_UI flag may suppress other error messages
    and may also have side-effects beyond the display of failure messages.
    See bug for details.
    
    Bug: 819809
    Change-Id: I8def155aa11b14f9a57a8f66add193dc281971cb
    Reviewed-on: https://chromium-review.googlesource.com/966963
    Commit-Queue: Asanka Herath <asanka@chromium.org>
    Reviewed-by: default avatarEric Lawrence <elawrence@chromium.org>
    Reviewed-by: default avatarScott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#548039}
    5bcdfd9c
shell.h 3.54 KB