• Olga Sharonova's avatar
    Revert "Perfetto: Fix ProducerClient threading/sequencing issues" · 5bf29200
    Olga Sharonova authored
    This reverts commit 2c2411fb.
    
    Reason for revert: Suspected cause of Issue 846609
    
    Original change's description:
    > Perfetto: Fix ProducerClient threading/sequencing issues
    > 
    > * TraceWriters will no longer be destroyed when their TLS slot is cleaned
    >   up on thread shutdown as this can trigger a CommitData() call from
    >   Perfetto and cause asserts when Mojo does a TaskRunnerHandle::Get()
    >   for a PostTask; instead we leave the deletion to the taskrunner
    >   Perfetto is running on (if it's getting shut down, the task should
    >   get dropped).
    > * Run ProducerClients on their own sequence.
    > 
    > Bug: 844379
    > Change-Id: Ie45b36a4e463674122555dbec2105953a882f37c
    > Reviewed-on: https://chromium-review.googlesource.com/1069528
    > Reviewed-by: Primiano Tucci <primiano@chromium.org>
    > Commit-Queue: oysteine <oysteine@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#561356}
    
    TBR=primiano@chromium.org,oysteine@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 844379
    Change-Id: I82eb4e335521ef8f39119bdd2a984f4dc81ac88c
    Reviewed-on: https://chromium-review.googlesource.com/1073247Reviewed-by: default avatarOlga Sharonova <olka@chromium.org>
    Commit-Queue: Olga Sharonova <olka@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#561823}
    5bf29200
trace_log.cc 59.8 KB