• Trent Apted's avatar
    Use gfx::Typesetter::BROWSER for url_formatter::ElideUrl() · 5c48792e
    Trent Apted authored
    StatusBarMac is the last remaining consumer of gfx:: elide and
    string width functions that draws Cocoa UI but is not passing info
    about the typesetter to use when eliding. It's also the only thing
    on Mac that uses url_formatter::ElideUrl(), so it's sufficient to
    pass gfx::Typesetter::BROWSER to ensure correct behavior.
    
    elide_url.cc is also the last remaining consumer of GetStringWidth
    that may draw to Cocoa UI but does not pass a typesetter. So,
    after this, gfx::Typesetter::DEFAULT can switch from BROWSER to
    HARFBUZZ to address subtle typesetting differences in Harmony UI,
    without adversely affecting any Cocoa browser UI. (gfx::Typesetter
    can disappear once mac_views_browser ships).
    
    Bug: 798927
    Change-Id: I6f5ff9b6a325b3b4c3b766ae5d9aabc6470ca8b5
    Reviewed-on: https://chromium-review.googlesource.com/856023Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
    Commit-Queue: Trent Apted <tapted@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#529603}
    5c48792e
elide_url.cc 22.3 KB