• Jiewei Qian's avatar
    ui: stop SettingsWindowManager from managing SWA OS Settings window · 5c5a1e04
    Jiewei Qian authored
    SWA has it's own logic for managing windows for OS Settings SWA.
    SettingsWindowManager should only be used for legacy OS Settings.
    
    This CL stops notifying observers about creation of SWA OS Settings
    windows. This is safe because the only use case is
    SettingsWindowObserver, which is only initialized if legacy settings
    window is used (but never initialized if SWA is used).
    
    See chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc.
    
    This CL is a preparation for https://crbug.com/1154540, where we
    implement a new LaunchSWA API. The new API uses AppService to launch the
    app, and won't return the Browser object hosting the app window.
    
    Bug: 1154540
    Change-Id: I7ba5d4bc1ab6928168b0bc17016ab6684ca1f2cd
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568340
    Commit-Queue: Jiewei Qian  <qjw@chromium.org>
    Auto-Submit: Jiewei Qian  <qjw@chromium.org>
    Reviewed-by: default avatarJames Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#834541}
    5c5a1e04
settings_window_manager_chromeos.cc 6.11 KB