• Ben Pastene's avatar
    Reland "Simplify Simple Chrome's gclient and GN conditionals." · 5c626330
    Ben Pastene authored
    This reverts commit 3d879e70.
    
    Reason for reland:
    - All hand-rolled DEPS-consuming apps have been updated.
    - No changes in this CL between original & reland.
    
    Original change's description:
    > Revert "Simplify Simple Chrome's gclient and GN conditionals."
    > 
    > This reverts commit 072cfd65.
    > 
    > Reason for revert: Needed to fix merge conflicts for revert in https://crrev.com/c/2289991.
    > 
    > Original change's description:
    > > Simplify Simple Chrome's gclient and GN conditionals.
    > > 
    > > Now uses the new gclient var 'cros_boards_with_qemu_images' for DEPS
    > > hooks as well as for building the data_deps for CrOS tests in GN.
    > > 
    > > Bug: 937821
    > > Change-Id: Ifdd05f09a4200328a06028be86aeb22c8486c65c
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285361
    > > Reviewed-by: Nico Weber <thakis@chromium.org>
    > > Reviewed-by: Dirk Pranke <dpranke@google.com>
    > > Commit-Queue: Ben Pastene <bpastene@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#786312}
    > 
    > TBR=thakis@chromium.org,dpranke@google.com,bpastene@chromium.org
    > 
    > Change-Id: If0b181d298f6a9368af88eaf658f0226e2161c68
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 937821
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289401
    > Reviewed-by: Michael Moss <mmoss@chromium.org>
    > Commit-Queue: Michael Moss <mmoss@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#786762}
    
    TBR=thakis@chromium.org,mmoss@chromium.org,dpranke@google.com,bpastene@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 937821
    Change-Id: Ia9759be4fcdf7dc510fefd9c020440478da5b8ad
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303031Reviewed-by: default avatarBen Pastene <bpastene@chromium.org>
    Reviewed-by: default avatarDirk Pranke <dpranke@google.com>
    Commit-Queue: Ben Pastene <bpastene@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#789644}
    5c626330
rules.gni 8.4 KB