• Fergal Daly's avatar
    Allow --enable-tracing-output to take a directory name. · 5c6698bf
    Fergal Daly authored
    PROBLEM: It is not possible to retrieve traces from swarming with
    --gtest_repeat.
    
    For a file to be retrievable from swarming, it must be placed in
    ${ISOLATED_OUTDIR} but specifying anything for --enable-tracing-output
    disables the unique-filename-per-test behaviour.
    
    With this change it becomes possible to do e.g.
    
    tools/mb/mb.py run ... \
      --gtest_filter=WebNavigationApiTest.Crash \
      --gtest_repeat=100
      --enable-tracing=*,disabled-by-default-toplevel.flow \
      --enable-tracing-output='${ISOLATED_OUTDIR}/'
    
    and have unique files for each test that are retrievable with swarming
    collect.
    
    Also drive-by fix typo in name of function.
    
    BUG=1043616
    
    Change-Id: Idd1bcbbdb6f18d297170f074e9409c61204fcacb
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445649
    Commit-Queue: Fergal Daly <fergal@chromium.org>
    Reviewed-by: default avatarNasko Oskov <nasko@chromium.org>
    Reviewed-by: default avatarAlexander Timin <altimin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#814052}
    5c6698bf
content_switches.cc 46.6 KB