• Miguel Casas's avatar
    RELAND: media/gpu/BUILD.gn: restrict image_processor, video_frame_mapper to CrOs, Chromecast · 5d5aae53
    Miguel Casas authored
    Original CL got reverted due to breaking ChromiumOS ASAN and
    Linux ChromiumOS MSan builders:
    
    [48790/51498] LINK ./content_shell
    FAILED: content_shell
    ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,--fatal-warnings -fPIC -Wl,-z,noexecsta...(too long)
    ld.lld: error: undefined symbol: media::ChromeosVideoDecoderFactory::GetSupportedConfigs()
    >>> referenced by gpu_mojo_media_client.cc:162 (../../media/mojo/services/gpu_mojo_media_client.cc:162)
    >>>               services/gpu_mojo_media_client.o:(media::GpuMojoMediaClient::GetSupportedVideoDecoderConfigs()) in archive obj/media/mojo/services/libmedia_mojo_services.a
    clang: error: linker command failed with exit code 1 (use -v to see invocation)
    
    Cq-Include-Trybots:luci-chromium-try:linux_chromium_chromeos_asan_rel_ng;luci-chromium-try:linux_chromium_chromeos_msan_rel_ng
    
    
    Original CL description ----------------------------------------------
    
    This CL restricts //media/gpu:image_processor and :video_frame_mapper
    to ChromeOS and ChromeCast, since they are only implemented for these
    platforms.  Same for image_processor_test.
    
    video_frame_file_writer.cc sandwiched some uses of |video_frame_mapper_|
    in an OS_LINUX and left others unprotected, which confused OS_WIN
    builds. This CL changes those to if defined(OS_CHROMEOS), since I
    don't think this file is meant to be compiled nor run on OS_LINUX.
    
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787467
    Commit-Queue: Miguel Casas <mcasas@chromium.org>
    Reviewed-by: default avatarHirokazu Honda <hiroh@chromium.org>
    Reviewed-by: default avatarYuchen Liu <yucliu@chromium.org>
    Cr-Original-Commit-Position: refs/heads/master@{#698566}
    Bug: 1006266
    Change-Id: I6c9982015829863694e9f48815105f371548f9a4
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816799Reviewed-by: default avatarDan Sanders <sandersd@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#698655}
    5d5aae53
BUILD.gn 829 Bytes