• leviw's avatar
    Revert of bluetooth: Move testing IPC from BluetoothDispatcher to... · 5e096ae8
    leviw authored
    Revert of bluetooth: Move testing IPC from BluetoothDispatcher to BlinkTestRunner (patchset #2 id:250001 of https://codereview.chromium.org/1125133005/)
    
    Reason for revert:
    Broke a bunch of Layout Tests. Here's an example: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=virtual%2Fstable%2Fanimations-unprefixed%2Fanimation-events-prefixed-04.html
    
    STDERR: ==28151==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000050 (pc 0x000006a00bd0 bp 0x7fff171be890 sp 0x7fff171be880 T0)
    STDERR:     #0 0x6a00bcf in content::BluetoothDispatcherHost::SetBluetoothAdapterForTesting(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) content/browser/bluetooth/bluetooth_dispatcher_host.cc:63:43
    STDERR:     #1 0x4e5d9d in OnSetBluetoothAdapter content/shell/browser/layout_test/layout_test_message_filter.cc:171:3
    STDERR:     #2 0x4e5d9d in DispatchToMethodImpl<content::LayoutTestMessageFilter, void (content::LayoutTestMessageFilter::*)(const std::__1::basic_string<char> &), std::__1::basic_string<char> , 0> base/tuple.h:252:0
    
    Original issue's description:
    > bluetooth: Move testing IPC from BluetoothDispatcher to BlinkTestRunner
    >
    > This patch removes the testing IPC from BluetoothDispatcher and
    > BluetoothDispatcherHost.
    >
    > This patch also changes the way the mock BluetoothAdapter was set in
    > BluetoothDispatcherHost. Instead of receiving an IPC to set the adapter,
    > BluetoothDispatcherHost exposes a function to directly set the adapter.
    > This function is used by LayoutTestSupport to set the adapter.
    >
    > Mock adapter flow before:
    > BlinkTestRunner -> LayoutTestSupport -> BluetoothDispatcher --IPC-->
    > BluetoothDispatcherHost (Mock constructed here)
    >
    > After:
    > BlinkTestRunner --IPC--> LayoutTestMessages(Mock constructed here) ->
    > LayoutTestSupport -> BluetoothDispatcherHost
    >
    > This is the first of two patches to remove testing from BluetoothDispatcher
    > and BluetoothDispatcherHost:
    >
    >  [1] This patch.
    >  [2] http://crrev.com/1132943002
    >
    > BUG=436284
    >
    > Committed: https://crrev.com/3f7142d0acf5e930743cbe5d754084c464ac3c85
    > Cr-Commit-Position: refs/heads/master@{#330647}
    
    TBR=jam@chromium.org,scheib@chromium.org,tsepez@chromium.org,ortuno@chromium.org
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=436284
    
    Review URL: https://codereview.chromium.org/1142303002
    
    Cr-Commit-Position: refs/heads/master@{#330653}
    5e096ae8
render_process_host_impl.h 18.9 KB