• Dominic Mazzoni's avatar
    Re-land: Fix accessibility dump tree tests to not need an end-of-file sentinel. · 5ec739fd
    Dominic Mazzoni authored
    Original: http://crrev.com/c/2109458
    Reverted: http://crrev.com/c/2111771
    
    This change depended on fixing all of the -expected*.txt files in
    content/test/data/accessibility, but another one landed before this
    one.
    
    The DumpAccessibilityTree tests generate an output text file and diff
    the results against an expected file. Previously, the way that the
    algorithm handled files of different lengths was by adding an
    end-of-file sentinel to the end. This resulted in that sentinel
    getting checked in, which was just confusing.
    
    Fix this by modifying the DiffLines helper function to properly compare
    files that don't have the same number of lines. Add full unit tests for
    DiffLines so we can be confident it works.
    
    Continue to LOG the end-of-file sentinel, because it's needed by
    running rebase_dump_accessibility_tree_test.py to parse actual output
    files from remote logs.
    
    Bug: 1063167
    Tbr: aleventhal@chromium.org
    Change-Id: I6c52bc77c3e4bb6e07d77971a5d748d9bf0d1f75
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112116Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#751945}
    5ec739fd
dump_accessibility_test_helper.cc 6.52 KB