• Alex Ilin's avatar
    Reland "[profiles] Clean up guest ephemeral profile on startup" · 5f31861b
    Alex Ilin authored
    This reverts commit b62892aa.
    
    Reason for revert: Removed the directory existence check that was
    failing. Directories are removed on a background thread and there is
    no reliable way of waiting until the remove is complete.
    
    Original change's description:
    > Revert "[profiles] Clean up guest ephemeral profile on startup"
    >
    > This reverts commit d660a480.
    >
    > Reason for revert:
    > Test fails:
    > https://ci.chromium.org/ui/p/chromium/builders/ci/Win%207%20Tests%20x64%20(1)/76721/overview
    >
    > Original change's description:
    > > [profiles] Clean up guest ephemeral profile on startup
    > >
    > > This CL fixes a bug which leads to the guest ephemeral profile not being
    > > cleaned up on startup if it has been left over in the previous session.
    > >
    > > ProfileManager::CleanUpEphemeralProfiles() needs to pass the `true`
    > > parameter in ProfileAttributesStorage::GetAllProfilesAttributes() to get
    > > the full list of registered profiles.
    > >
    > > Bug: 1167883
    > > Change-Id: I3051a9174e8472eb2af046126be88dbfb44bcb47
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635158
    > > Commit-Queue: Alex Ilin <alexilin@chromium.org>
    > > Reviewed-by: David Roger <droger@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#844749}
    >
    > TBR=droger@chromium.org,alexilin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
    >
    > Change-Id: I6fb55866ddcda42c54d60aaa2e823da18b353348
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 1167883
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637395
    > Reviewed-by: Xida Chen <xidachen@chromium.org>
    > Commit-Queue: Xida Chen <xidachen@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#844779}
    
    TBR=droger@chromium.org,xidachen@chromium.org,alexilin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
    
    # Not skipping CQ checks because this is a reland.
    
    Bug: 1167883
    Change-Id: I8f78c419804e91aaa6279660160a6310353415ab
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637479Reviewed-by: default avatarDavid Roger <droger@chromium.org>
    Commit-Queue: Alex Ilin <alexilin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#844904}
    5f31861b
profile_manager.cc 85.4 KB