GitLab

Previously, using the clipboard on a non-whitelisted thread triggered
a DumpWithoutCrashing + NOTREACHED. If a developer introduced code that
used the clipboard on an incorrect thread, they were not warned
immediately unless they had DCHECKs enabled. The issue could only be
noticed once an official version of Chrome started generating crash
reports via DumpWithoutCrashing (e.g. https://crbug.com/872737). This
CL replaces the DumpWithoutCrashing + NOTREACHED with a CHECK to
ensure that developers can't miss the issue.

Bug: 872737
Change-Id: I5de2c1498245604fc94ca29c35518cc0c9531b0f
Reviewed-on: https://chromium-review.googlesource.com/1170595Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582323}