• Bruce Dawson's avatar
    Fix vs_toolchain.py for Python 3 · 5f9def8b
    Bruce Dawson authored
    vs_toolchain.py gets a directory listing for win_sdk_dir\bin and then
    sorts it by converting the 10.x.x.x directory names to tuples of
    integers. This fails on Python 3 because int and str types are not
    comparable so directories with non-integral (non-version) names caused
    comparison failures when compared against integral (version) names. This
    change filters out the unwanted names before sorting instead of after
    sorting, which lets this work on Python 3 (tested by running manually).
    
    A misleading variable name was also changed.
    
    This was reported by a pdfium user.
    
    Change-Id: Ifb0accd831945c6d0eb44e838071b8ddd609ddb2
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309454
    Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
    Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
    Reviewed-by: default avatarEdward Lesmes <ehmaldonado@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#790446}
    5f9def8b
vs_toolchain.py 22.9 KB