• Darren Shen's avatar
    Revert "Reduce leaks in PostTaskAndReplyImpl::PostTaskAndReply." · 5fb329ce
    Darren Shen authored
    This reverts commit 970f8498.
    
    Reason for revert: Appears to be causing leaks in chromeos_unittests (PipeReaderTest.Cancel).
    
    Bot: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/
    
    Build failure: 
    https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_Chromium_OS_ASan_LSan_Tests__1_%2F26886%2F%2B%2Frecipes%2Fsteps%2Fchromeos_unittests%2F0%2Fstdout
    
    Original change's description:
    > Reduce leaks in PostTaskAndReplyImpl::PostTaskAndReply.
    > 
    > Before, there was always a leak when the RunTaskAndPostReply callback
    > posted by PostTaskAndReplyImpl::PostTaskAndReply didn't run.
    > 
    > With this CL, the "task" is never leaked and the "reply" is only
    > leaked if the execution environment is shutdown before the deletion
    > happens (e.g. MessageLoop deleted, TaskScheduler shutdown).
    > 
    > Bug: 807013
    > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
    > Change-Id: I05205d1b0250811abe61e2204ba32919d16c16c0
    > Reviewed-on: https://chromium-review.googlesource.com/902191
    > Reviewed-by: François Doray <fdoray@chromium.org>
    > Reviewed-by: Scott Violet <sky@chromium.org>
    > Reviewed-by: Kenneth Russell <kbr@chromium.org>
    > Reviewed-by: Gabriel Charette <gab@chromium.org>
    > Commit-Queue: François Doray <fdoray@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#548034}
    
    TBR=sky@chromium.org,gab@chromium.org,fdoray@chromium.org,kbr@chromium.org,tzik@chromium.org
    
    Change-Id: Ib91c72333fabb4e33c1689c5ad39a5ed53ce3beb
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 807013
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
    Reviewed-on: https://chromium-review.googlesource.com/996732Reviewed-by: default avatarDarren Shen <shend@chromium.org>
    Commit-Queue: Darren Shen <shend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#548243}
    5fb329ce
post_task_and_reply_impl.h 1.45 KB