• Vasilii Sukhanov's avatar
    Revert "blink image_decode_bench: use more Chromium stuff" · 6089db66
    Vasilii Sukhanov authored
    This reverts commit 1c320598.
    
    Reason for revert: broke compilation on Win
    https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8932944647631542128/+/steps/compile/0/stdout
    
    ../../third_party/blink/renderer/platform/testing/image_decode_bench.cc(43,26):  error: no matching conversion for functional-style cast from 'const char *' to 'base::FilePath'
        const auto file_path = base::FilePath(name);
    
    Original change's description:
    > blink image_decode_bench: use more Chromium stuff
    > 
    > This CL refactors image_decode_bench:
    > - Rewrites function ReadFile() to use base::FilePath etc.
    > - Configures the Logging and changes fprintf/stderr to LOG()
    >  statements, and exit()s into LOG_ASSERT().
    > - Names the constant kDefaultDecodeTimes.
    > - s/DecodeError/PrintErrorAndExit/ to clarify what it does.
    > - Changes uses of CurrentTimeTicks() with base::ElapsedTimer,
    >  and uses TimeDelta ISO double to count the elapsed time.
    > - Uses perf_test::PrintResult to add info about the image
    >  (size and #pixels), when a new parameter (-v / -verbose)
    >  is specified after the current two parameters, file and
    >  #iterations; output is e.g.:
    > *RESULT decode_time /usr/local/google/home/mcasas/Pictures/4.webp: 100 times 790528 pixels (1024x772)= 66.27827 ms/sample
    > 
    > Bug: 889898
    > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    > Change-Id: Ic0a66d2aa3d2f08b13c8af99aed31e61d7246dec
    > Reviewed-on: https://chromium-review.googlesource.com/c/1225653
    > Commit-Queue: Miguel Casas <mcasas@chromium.org>
    > Reviewed-by: Leon Scroggins <scroggo@chromium.org>
    > Reviewed-by: Noel Gordon <noel@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#598803}
    
    TBR=scroggo@chromium.org,noel@chromium.org,mcasas@chromium.org
    
    Change-Id: I7f18f8a464536eb5b6cee86f25930a94f357a0f1
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 889898
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Reviewed-on: https://chromium-review.googlesource.com/c/1277245Reviewed-by: default avatarVasilii Sukhanov <vasilii@chromium.org>
    Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#598809}
    6089db66
BUILD.gn 72.6 KB