• Joey Arhar's avatar
    Reland "media/video: Add SpatialLayer to VideoEncodeAccelerator::Config" · 60b3f6a7
    Joey Arhar authored
    This reverts commit ddcb2103.
    
    Reason for revert:
    The revert caused a compile error, so I am relanding it. I will then disable the test that was failing on msan instead.
    
    Original change's description:
    > Revert "media/video: Add SpatialLayer to VideoEncodeAccelerator::Config"
    > 
    > This reverts commit ee98d31c.
    > 
    > Reason for revert:
    > After the commit, SpatialLayerStructTraitTest.RoundTrip has been
    > consistently failing on msan.
    > 
    > I was able to reproduce the failure locally on my linux machine by
    > building and running media_unittests with these gn args:
    > is_component_build = false
    > is_debug = false
    > is_msan = true
    > msan_track_origins = 2
    > use_goma = true
    > 
    > Original change's description:
    > > media/video: Add SpatialLayer to VideoEncodeAccelerator::Config
    > > 
    > > This CL adds SpatialLayer to VideoEncodeAccelerator::Config so
    > > that a VEA client is able to configure a spatial layer encoding.
    > > The configuration is useful to configure temporal layer encoding
    > > too. Supporting temporal layer with vp9 hw encoder is a short
    > > term goal today.
    > > 
    > > Design doc: https://docs.google.com/document/d/1yeCV36yhk9zna4qwngPiJGhSUkDyJHRlfEpziFgJfHo#heading=h.aeh6kjktcuzy
    > > 
    > > Bug: 1030199
    > > Test: media_unittests
    > > Change-Id: I1e0524a71b043ccfa0e41d08e8de4b86e9c17c9e
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131444
    > > Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
    > > Reviewed-by: Dominick Ng <dominickn@chromium.org>
    > > Reviewed-by: Dan Sanders <sandersd@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#756300}
    > 
    > TBR=sandersd@chromium.org,sprang@chromium.org,dominickn@chromium.org,hiroh@chromium.org,ilnik@chromium.org
    > 
    > Change-Id: I6a86cb5a8f7d5fd2d1b7dbd4b3d6d99d2298c5dd
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 1030199,1067758
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136113
    > Reviewed-by: Joey Arhar <jarhar@chromium.org>
    > Commit-Queue: Joey Arhar <jarhar@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#756427}
    
    TBR=sandersd@chromium.org,sprang@chromium.org,dominickn@chromium.org,hiroh@chromium.org,ilnik@chromium.org,jarhar@chromium.org
    
    Change-Id: If73b6e850248954c8709acc86b923d67dc11597a
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1030199, 1067758
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136226Reviewed-by: default avatarJoey Arhar <jarhar@chromium.org>
    Commit-Queue: Joey Arhar <jarhar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#756431}
    60b3f6a7
video_encode_accelerator.mojom 5.43 KB