• Darren Shen's avatar
    [VK] Draw shadows for docked keyboard. · 60b9c2ff
    Darren Shen authored
    In a previous patch, we removed shadows for both docked and floating
    keyboard so that IME can draw them. Unfortunately, this means that
    KeyboardController no longer knows which area of the keyboard is the
    shadow and which is the actual UI, which breaks things like overscrolling.
    
    A fix would be to make IME indicate what the actual occluded bounds are
    through setOccludedBounds. Unfortunately, setOccludedBounds has several
    problems (e.g. what happens when occluded bounds and visual bounds go
    out of sync, e.g. when the screen is rotating). This requires some
    additional thought.
    
    So in the meantime, we just draw shadows only for docked mode. This will
    at least unblock the new UI while we find a permanent solution.
    
    Bug: 867775
    Change-Id: Iebd8f5edfeac5643fe837b672bf65dab5bfcdb4d
    Reviewed-on: https://chromium-review.googlesource.com/1152328
    Commit-Queue: Darren Shen <shend@chromium.org>
    Reviewed-by: default avatarYuichiro Hanada <yhanada@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#578979}
    60b9c2ff
keyboard_controller_browsertest.cc 12.3 KB