-
Jan Wilken Dörrie authored
This reverts commit 978f825e. Reason for revert: Breaks Linux MSAN due to use-of-uninitialized-value: https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/24094 Original change's description: > [omnibox] [rich-autocompletion] Add multi-sel & comp-text to OmniboxView > > *Rich autocompletion background* > > Currently, autocompletion is limited to when the user types a prefix of > the URL. E.g. 'wiki' can autocomplete 'wiki.org/thecookinglist - top > awesome recipes'. > > Rich autocompletion will allow autocompletion even when the input is > from the suggestion title or middle of the URL. E.g. 'thecoo' and > 'recip' will also autocomplete 'wiki.org/thecookinglist - top awesome > recipes'. > > Design doc with further details: go/richomniboxautocompletion > > Previous CLs: > - crrev.com/c/2107796 added chrome://flags flags > - crrev.com/c/2108780 supported multiselection in textfield views. > - crrev.com/c/2199859 Add complementary omnibox view. > > *This CL* > > This is the 4th CL for rich autocompletion. It wires in the omnibox view > to textfield's multiselection & location bar's complementary text. > > This CL has no user facing changes. Followup CLs will wire in rich > autocompletion to make use of these changes. > > Bug: 1062446 > Change-Id: I919965049837fd5421fd2b8f0dabc6d3489dabf4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204545 > Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> > Auto-Submit: manuk hovanesian <manukh@chromium.org> > Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772612} TBR=tommycli@chromium.org,stkhapugin@chromium.org,manukh@chromium.org Change-Id: I0ee50606f616c59fe7233ada53518c3d01b3c2a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1062446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219891Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#772648}
6103f375