-
Victor Costan authored
https://crrev.com/c/1338177 relaxed the DCHECKs for sql::Database::GetCachedStatment by allowing the SQL statement argument to have leading and trailing whitespace when compared with the SQL statement reported by SQLite. This CL reverts the relaxed restriction. Instead, GetCachedStatement will also DCHECK that the SQL statement argument matches the SQL statement reported by SQLite when preparing the statement. This will help developers discover non-canonical statements on first use. Bug: 894884 Change-Id: I166f8cda8d5a3980d9858a26507f778bc87ee6cc Reviewed-on: https://chromium-review.googlesource.com/c/1341493 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#609605}
613b4307