• Jason Lin's avatar
    Reland "Factor non-ui logic out of CrostiniInstallerView" · 61881e05
    Jason Lin authored
    This is a reland of bbe68ab3
    
    This reland resolves the following issues:
    
    * CrostiniInstallerViewBrowserTest fails to pass MSAN
    * CrostiniInstallerTest is flaky
    
    Also note that the original description links to the wrong issue
    crbug.com/912638 instead of crbug.com/929571.
    
    Original change's description:
    > Factor non-ui logic out of CrostiniInstallerView
    >
    > The current CrostiniInstallerView contains a lot of non-ui logic such as
    > histogram recording and somewhat complex interaction with CrostiniManager. This
    > CL factors out the non-ui logic into new class CrostiniInstaller. This not only
    > makes the code cleaner, but also allows us to port the installer UI to WebUI
    > much more easily.
    >
    >
    > Bug: 912638
    > Change-Id: Ie0195c8580518aa39e59aa539ef2fb614978776b
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701024
    > Reviewed-by: Ben Wells <benwells@chromium.org>
    > Reviewed-by: Timothy Loh <timloh@chromium.org>
    > Commit-Queue: Jason Lin <lxj@google.com>
    > Cr-Commit-Position: refs/heads/master@{#688021}
    
    Bug: 929571,995261,992298
    Change-Id: I85809d7760ee99fa1100e303aadf04837db9666b
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760640Reviewed-by: default avatarTimothy Loh <timloh@chromium.org>
    Reviewed-by: default avatarBen Wells <benwells@chromium.org>
    Commit-Queue: Jason Lin <lxj@google.com>
    Cr-Commit-Position: refs/heads/master@{#689347}
    61881e05
crostini_installer.cc 21.9 KB