-
Kyle Milka authored
This is a reland of 5d52425f Initialize the int memebers of SearchSuggestData to 0. The uninitialized values were causing separate failures than the previously flaky test. Original change's description: > Reland "[NTP] Cap search suggestion impressions" > > This is a reland of 41e54be1 > > One of the checks is converting the times from ms->s. In practice > seconds is plenty precise but in the test 800ms ended up being 0, > so increase it to 1000ms (similar to ImpressionCountResetsAfterTimeout > which was not flaky). > > Original change's description: > > [NTP] Cap search suggestion impressions > > > > The parameters for capping suggestions impressions are provided as part > > of the update proto. Read and update the local pref on each fetch. Use > > these prefs to determine if the impression cap has been reach or if > > fetching is frozen due to an empty response. > > > > Bug: 904565 > > Change-Id: Ib5539a99f18e9da2ac1223ecc7aff65cb909bca8 > > Reviewed-on: https://chromium-review.googlesource.com/c/1395188 > > Commit-Queue: Kyle Milka <kmilka@chromium.org> > > Reviewed-by: Kristi Park <kristipark@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#624994} > > Bug: 904565 > Change-Id: I424cb51d2a9c1738c0e5168f58ef52b73ed4b223 > Reviewed-on: https://chromium-review.googlesource.com/c/1431472 > Reviewed-by: Kristi Park <kristipark@chromium.org> > Commit-Queue: Kyle Milka <kmilka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625437} Bug: 904565 Change-Id: I01e2c868d36ce1ab5d7ffd91b86e40d8573f121e Reviewed-on: https://chromium-review.googlesource.com/c/1434081Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#625786}
621811e4