GitLab

Port forwarding in Cros will allow users to add new ports and activate,
deactivate and remove existing ports.

When any of the utilities are called, the port forwarding library will
invoke the permission broker client to change the ChromeOS port
forwarding settings.

In future work we will also save port forwarding preferences such that a
user's preferences will persist over container shutdown.

Revert CL comment:
Reason for revert: CrostiniPortForwarderTest.AddPortDuplicateFail failing on Linux Chromium OS ASan LSan Tests (1)

First failing build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/36750

Failure example:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8890488549187658624/+/steps/unit_tests/0/logs/Deterministic_failure:_CrostiniPortForwarderTest.AddPortDuplicateFail__status_CRASH_/0

Actions taken:
Built tests and ran with address sanitizer, confirmed
existence of issue. Made appropriate changes and confirmed address
sanitizer does not raise issues anymore.

everything builds

Bug: chromium:848127
Test: crostini_port_forwarder_unittest.cc (+Address Sanitizer) and
Change-Id: Ib1d1b901b9f9e45fb7e85feaa0b97be026feabac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018363Reviewed-by: Nic Hollingum <hollingum@google.com>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Matthew Chen <matterchen@google.com>
Cr-Commit-Position: refs/heads/master@{#735761}