• Mirko Bonadei's avatar
    Stop using -isystem and -imsvc because "gn check" ignores them. · 62331d00
    Mirko Bonadei authored
    Gn check can enforce dependencies only if the header is included with
    an absolute path (from the root of the project) or if "include_dirs"
    is used. It ignores -isystem and -imsvc since they are part of
    cflags (and similar variants).
    
    Since //third_party/abseil-cpp/absl:absl_include_config was using
    -isystem and -imsvc only to sidestep compiler warnings in absl code,
    it is good to try to switch back to include_dirs instead of adding
    -isystem/-imsvc support to "gn check".
    
    Bug: 862521
    Change-Id: I9c2d01abad75023918a88f852e3080486dcafead
    Reviewed-on: https://chromium-review.googlesource.com/1124478
    Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
    Reviewed-by: default avatarNico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#577535}
    62331d00
BUILD.gn 1.86 KB