• Chris Lu's avatar
    [ios] Fix BadgeViewController interpretation of badgeState · 6288d7c0
    Chris Lu authored
    Since BadgeState is a mask, a direct equality comparison to
    BadgeState values for the BadgeItem properties is not the correct
    way to assess if a badge is accepted.
    
    To add testing support for this case, accepted a11y identifiers
    for BadgeButtons are created, and they will be properly set
    in setAccepted: in BadgeButton.
    
    This change is a relanding of crrev.com/c/1872938, which failed because
    iPhone SE's screen was not wide enough to contain all the view in Showcase.
    Changes were made in sc_badge_coordinator to create two rows instead of
    one.
    
    Bug: 976901, 1016793
    Change-Id: Iadc7e3e42529ded0aa331da3845e8644e4cac9c2
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881364
    Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
    Reviewed-by: default avatarPeter Lee <pkl@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#709675}
    6288d7c0
badge_constants.mm 1.55 KB