• Alexander Cooper's avatar
    Migrate ArCoreInstallHelper to use components/infobars · 62e4262b
    Alexander Cooper authored
    In order to migrate the InstallHelpers out of chrome, their dependency
    on SimpleConfirmInfoBarBuilder needs to be broken. This change creates a
    class that both InstallHelpers can use, XrInstallInfoBar, which inherits
    from the components ConfirmInfoBar. ArCoreInstallHelper is also modified
    to take in a ContentInfoBarManager to display this item, so that it can
    be moved to components when the corresponding ArCoreInstallUtils java
    class can be moved. Unfortunately, content does not have a good way to
    get the specific InfoBarManager at this time, so a wrapper class is
    created to get the embedder-specific InfoBarManager.
    
    Note that due to the dependency on the ArCoreShim, ArCoreInstallUtils
    cannot be moved out of //chrome just yet.
    
    Due to the fact that the VrCoreInstallHelper lives in the VR DFM, some
    issues arose around strings when attempting to port it, so this change
    only ports the ArCoreInstallHelper to the new classes.
    
    Bug:1064073,960542
    
    Change-Id: Icec9bd2535dde0378c16aafc9bafd98db4927ed2
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442990
    Commit-Queue: Alexander Cooper <alcooper@chromium.org>
    Reviewed-by: default avatarPiotr Bialecki <bialpio@chromium.org>
    Reviewed-by: default avatarMichael Thiessen <mthiesse@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#814368}
    62e4262b
xr_install_infobar.h 2.04 KB