• Andrew Xu's avatar
    Fix hotseat bounds animation recorder · 632a0769
    Andrew Xu authored
    Hotseat bounds animation recorder reports the animation smoothness
    for each hotseat state. However, the hotseat state used by
    animation recorder is set by HotseatTransitionAnimator which may not
    run when hotseat state changes. As a result, the animation smoothness
    may be included by the wrong histogram.
    
    In order to access the target hotseat state when starting the hotseat
    bounds animation, the hotseat state stored in hotseat widget updates
    before setting bounds. Although the comment in old code explains
    why it is necessary to update the hotseat state after setting bounds,
    swapping the order does not bring any visual difference; neither does
    it break any test case.
    
    The test case for hotseat bounds animation recorder will be implemented
    after https://crbug.com/1044306 is solved which disables the widget
    animation waiter.
    
    Bug: 1059603
    Change-Id: I0cea5ae33b9b137b786713691d0d1bac232c652b
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095933Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
    Commit-Queue: Andrew Xu <andrewxu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#749792}
    632a0769
shelf_layout_manager.cc 99.8 KB