-
erikchen authored
The concept of "working set" is specific to the Windows memory model. * Windows-only files were modified to directly invoke the Windows API. * os_metrics_linux.cc was modified to use RSS instead [which is what they really wanted]. * Two iOS files were incorrectly using GetWorkingSetSize() to return a task's "resident_size" as a rough measurement for total memory usage. This is inaccurate, since it includes reusable memory [used extensively by libMalloc for freeing objects]. This CL changes those two files to directly invoke the relevant mach APIs, and to subtract out reusable memory. * Remoting was using GetWorkingSetSize on all platforms, but the concept is only well defined on Windows. * MemoryCoordinator was calling GetWorkingSetSize from dead code. The dead code was removed. Bug: 819289 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I720e18ab483a9995982762cbd5ae1d045adfaa74 TBR: sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/953723 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#541896}
d447bb62