• Morten Stenshorne's avatar
    [LayoutNG] Improved legacy write-back for multicol. · 63cac401
    Morten Stenshorne authored
    This fixes crashers in layout tests.
    
    A recent change, probably
    https://chromium-review.googlesource.com/c/chromium/src/+/912551
    triggered a bunch of crashers in fast/multicol/ , because it calls
    LayoutFlowThread::PageRemainingLogicalHeightForOffset(), which DCHECKs
    on IsPageLogicalHeightKnown(). So have NG mark logical height as known,
    to avoid the DCHECK failure.
    
    In addition to fixing those 91 new crashers (note that the test
    expectation file hadn't been updated to expect crashers for those), this
    also fixes some old crashers. Most of them go from Crash to Failure, but
    a few even pass now.
    
    Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
    Change-Id: Ia3405e7dc18cb11026927836d07be5e3271817bb
    Reviewed-on: https://chromium-review.googlesource.com/921227
    Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
    Reviewed-by: default avatarKoji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#537005}
    63cac401
enable-blink-features=LayoutNG 565 KB