• Charlie Andrews's avatar
    Fill in StackSampler static functions for Android · 63dbdf68
    Charlie Andrews authored
    There are existing POSIX implementations for these methods in
    stack_sampler_posix.cc. We now use stack_sampler_android.cc on Android
    and stack_sampler_posix.cc on all other POSIX platforms.
    
    Note that there's an existing StackSamplerAndroid that exists in the
    tracing namespace. However, that implementation is only used for the
    "cpu_profiler" tracing category, whereas this implementation will be
    used for stack sampled metrics. Once this new Android profiler is
    sufficiently complete, it will also be used for tracing.
    This stack_sampler_android.cc defers to StackSamplerImpl for its core
    logic (also used by the Windows and Mac sampling profiler
    implementations), whereas tracing's stack_sampler_android doesn't use
    StackSamplerImpl and implements its own core logic.
    
    R=wittman@chromium.org,gab@chromium.org
    
    Bug: 988574
    Change-Id: Ia1f20a22ac1421ff02d4beecff4beb6b7a0e065f
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727230Reviewed-by: default avatarGabriel Charette <gab@chromium.org>
    Reviewed-by: default avatarMike Wittman <wittman@chromium.org>
    Commit-Queue: Charlie Andrews <charliea@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#682446}
    63dbdf68
stack_sampler_android.cc 1.27 KB