• Alexei Svitkine's avatar
    Revert "Add full system profiles in .pma file as part of metrics init." · 6502eb0f
    Alexei Svitkine authored
    This reverts commit 87dac882.
    
    Reason for revert: Breaks UMA recording.
    
    Original change's description:
    > Add full system profiles in .pma file as part of metrics init.
    > 
    > Prior to this change, only an incomplete system profile, notably
    > missing field trials and uma_default_state fields, was stored
    > at this point. So unclean shut downs after this point in time,
    > but before the initial metrics log was saved would not include
    > that info. This change fixes that by running the code that
    > populates all the system profile fields.
    > 
    > Since we're now calling ProvideSystemProfileMetrics() twice, the
    > logic in FieldTrialsProvider was no longer correct in tracking
    > the log creation time. Instead, this CL updates the API to have
    > that be passed in.
    > 
    > Additionally, Chrome OS an Screen Info providers needed updates since
    > their dependencies are not yet available this early, so they are not
    > able to provide all the information this early.
    > 
    > Finally, webview unit tests needed updating to init mojo as they are
    > now exercising the provider code which has a Mojo dependency.
    > 
    > Bug: 992538
    > TBR: sky@chromium.org
    > Change-Id: Iae54398065470e390b70507d5b3ac09d5a983c9f
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746909
    > Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
    > Reviewed-by: Richard Coles <torne@chromium.org>
    > Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    > Reviewed-by: Brian White <bcwhite@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#687000}
    
    TBR=sky@chromium.org,rkaplow@chromium.org,asvitkine@chromium.org,torne@chromium.org,bcwhite@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 992538
    Change-Id: I4a25324788960d2e61325c2a41812c5da18087f8
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760869Reviewed-by: default avatarAlexei Svitkine <asvitkine@chromium.org>
    Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#688146}
    6502eb0f
chromeos_metrics_provider.cc 17.4 KB