• Mugdha Lakhani's avatar
    [WebLayer] SecurityLevel+VisibleSecurityState from delegate. · 65bd7e54
    Mugdha Lakhani authored
    Update PageInfo to get SecurityLevel and VisibleSecurityState from the
    delegate, which moves a lot of duplicated logic from wherever PageInfo
    is constructed into the delegate, and will also make componentizing
    ConnectionInfoPopup and PageInfoController easier, because the
    dependency on SecurityStateTabHelper won't be necessary.
    
    UpdateSecurityState and ComputeUIInputs don't need SecurityLevel and
    VisibleSecurityState, and have been updated to get them directly from
    the delegate instead.
    
    PageInfoTest was setting custom values for these, and so a test-only
    method to set security state has been added.
    
    Bug: 1052375
    Change-Id: Icf09eba58654d46ca9f9bf075364c1f00793db91
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128107
    Commit-Queue: Mugdha Lakhani <nator@chromium.org>
    Reviewed-by: default avatarJohn Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#755050}
    65bd7e54
page_info_unittest.cc 62.9 KB