GitLab

Including directories full of generated files causes incorrect incremental
builds.

But using data_deps makes it easy to copy just the generated files here,
so just do that instead.

To make sure this does the right thing, I ran

  gn gen out/gn --runtime-deps-list-file=<(echo //chrome/test:browser_tests)

with and without this patch and compared out/gn/browser_tests.runtime_deps.

The diff is

-test_case.html
-test_case.html.mock-http-headers
-test_page.css
-test_page.css.mock-http-headers
-test_url_loader_data/
+corb_eligible_resource.json
+corb_eligible_resource.json.mock-http-headers
+test_case.html
+test_case.html.mock-http-headers
+test_page.css
+test_page.css.mock-http-headers
+test_url_loader_data/hello.txt
-corb_eligible_resource.json
-corb_eligible_resource.json.mock-http-headers
-test_case.html
-test_case.html.mock-http-headers
-test_page.css
-test_page.css.mock-http-headers


Importantly, `test_url_loader_data/` no longer appears. (For some reason,
the non-directories were listed twice previously.)

We now bundle corb_eligible_resource when we weren't previously,
but that seems fine.

I then downloaded an isolate from the command printed on a browser_tests
run on swarming like so:

  tools/swarming_client/isolateserver.py download -I https://isolateserver.appspot.com \
      --namespace default-gzip -s 60fe18ca29dd47b47425717c01e67516cc26d6bf \
      --target foo

and verified that these are in fact all files:

    $ ls foo/out/Release/test_url_loader_data/
    hello.txt

Bug: 912946
Change-Id: I1ad01f8b53a1eb47c5b572ad645b1901305fcbc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769213Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690946}