• Eric Seckler's avatar
    Reland 2 "tracing: Enable startup tracing for spawned child processes" · 660ffc49
    Eric Seckler authored
    This is a reland of fd8826a6.
    
    Includes a further fix to BackgroundTracingActiveScenario, which was
    accidentally setting a default-sized trace buffer for all its sessions
    and causing OOMs (crbug.com/997610). Also rebased after non-perfetto
    tracing backend was removed recently. Relevant changes in PS 2 -> 5.
    
    > Reland "tracing: Enable startup tracing for spawned child processes"
    >
    > This is a reland of e40282f6.
    >
    > Includes a fix to BackgroundTracingActiveScenario, which could end up enabling
    > TraceLog without installing the TraceEventDataSource overrides on Android, see
    > patch set 1 -> 2. This likely caused the crashes observed in crbug.com/997582.
    >
    > Original change's description:
    > > tracing: Enable startup tracing for spawned child processes
    > >
    > > Enables startup tracing for child processes spawned by the browser while
    > > a tracing session is active.
    > >
    > > This allows us to collect early trace events in the period of time
    > > before the child connects to the tracing service.
    > >
    > > Bug: 968424
    > > Change-Id: I1708cabae77cdd2ab3a33929c28cfab04eb723e3
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755746
    > > Commit-Queue: Eric Seckler <eseckler@chromium.org>
    > > Reviewed-by: Avi Drissman <avi@chromium.org>
    > > Reviewed-by: ssid <ssid@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#689599}
    >
    > Bug: 968424
    > Change-Id: Id69f0821671caf05238896d4a0e1b581b5d5be44
    > TBR: avi@chromium.org
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782812
    > Commit-Queue: Eric Seckler <eseckler@chromium.org>
    > Reviewed-by: Avi Drissman <avi@chromium.org>
    > Reviewed-by: ssid <ssid@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#694981}
    
    Bug: 968424, 997610
    Change-Id: Idd63d6c69ded2d8ff56641c7a39de57847809cf0
    TBR: avi@chromium.org,ssid@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832202Reviewed-by: default avatarEric Seckler <eseckler@chromium.org>
    Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
    Commit-Queue: Eric Seckler <eseckler@chromium.org>
    Commit-Queue: Avi Drissman <avi@chromium.org>
    Auto-Submit: Eric Seckler <eseckler@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#701213}
    660ffc49
startup_tracing_browsertest.cc 7.9 KB