• Peter Collingbourne's avatar
    Only add runtime dependencies to the ordered libraries list. · 66205b64
    Peter Collingbourne authored
    We cannot find library dependencies to add to a target's ordered
    libraries list by searching the build directory because the build
    directory may contain libraries that appear to be dependencies but are
    in fact unrelated libraries that share a name with a system library
    that the target depends on. For example, we may be building a target
    that depends on the system's libGLESv2.so, and the build directory may
    contain a library named libGLESv2.so as a result of building ANGLE. The
    resulting APK would try to load libGLESv2.so using the crazy linker,
    which might fail to load the system's library.
    
    The solution is to use GN's write_runtime_deps feature to export the
    runtime dependency list from the build system and create an ordered
    libraries list from that.
    
    Bug: 742655
    Change-Id: Ifdbf3de6b78b56af22dbfe0d12d80db5a48fe9db
    Reviewed-on: https://chromium-review.googlesource.com/821600Reviewed-by: default avataragrieve <agrieve@chromium.org>
    Commit-Queue: Peter Collingbourne <pcc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#523675}
    66205b64
rules.gni 112 KB