• Bruce Dawson's avatar
    Revert "Switch to full 17763 SDK, including new d3dcompiler_47.dll" · 666e6630
    Bruce Dawson authored
    This reverts commit d17a7e3c.
    
    Reason for revert: Increase in heap corruption (and other?) crashes
    in the d3dcompiler code path, such as  crbug.com/932359. We have run
    out of time to investigate before branching.
    
    Original change's description:
    > Switch to full 17763 SDK, including new d3dcompiler_47.dll
    >
    > The new (10.0.17763.0) version of d3dcompiler_47.dll contains various
    > bug fixes which we want to ship. We initially avoided upgrading it with
    > the rest of the SDK because it depends on the universal Windows 10 CRT
    > (UCRT) which some Windows 7 machines lack. This caused test failures on
    > some bots and would cause failures on some customer machines.
    >
    > This change updates how we package isolates so that they always include
    > the UCRT, to avoid test failures. It also ships api-ms-win-*.dll and
    > ucrtbase*.dll in mini_installer.exe so that the UCRT will be shipped to
    > customers. The size increase to mini_installer.exe for this is about
    > 400,000 bytes.
    >
    > This change also deletes an unused function (_read_configuration_from_gn)
    > from create_installer_archive.py that sent me down an incorrect path
    > while investigating fixes.
    >
    > The toolchain package is the same as the one used when landing
    > crrev.com/c/1401403 except that the 17763 version of d3dcompiler_47.dll
    > was retained. See that CL for full instructions on creating the
    > toolchain package.
    >
    > Bug: 920704
    > Change-Id: I9cb7a7ed5cb75d04962fc64869d26b12617c0463
    > Reviewed-on: https://chromium-review.googlesource.com/c/1450414
    > Reviewed-by: Greg Thompson <grt@chromium.org>
    > Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#629193}
    
    TBR=brucedawson@chromium.org,grt@chromium.org
    
    Bug: 920704
    Change-Id: Ia986017541e5e80a3cc5f1d96494e0e12a841ed1
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507040Reviewed-by: default avatarJamie Madill <jmadill@chromium.org>
    Reviewed-by: default avatarBruce Dawson <brucedawson@chromium.org>
    Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#638596}
    666e6630
chrome.release 3.04 KB