• David Staessens's avatar
    Revert "media/gpu/vaapiWrapper: Enforce supported resolutions in CreateContext()" · 667dc36e
    David Staessens authored
    This reverts commit 72c52cf1.
    
    Reason for revert: Reason for revert: This breaks lower resolution test cases in ARC++/ARCVM: b/175515392
    
    Original change's description:
    > media/gpu/vaapiWrapper: Enforce supported resolutions in CreateContext()
    >
    > VaapiWrapper reports the supported min and max resolutions by
    > VaapiWrapper::GetSupportedDec/EncodeProfiles(). They might be
    > different from the min and max resolutions supported by a
    > hardware and driver for some reason. For instance, we set
    > the minimum encoder resolution to 321x241 and the webrtc encoder
    > enforces the resolution per kWebRtcUseMinMaxVEADimensions
    > (e.g. crbug.com/1008491).
    > Clients of VaapiWrapper were expected to respect the supported
    > resolutions, but could still request values outside of that
    > range, thus using hardware codecs unintentionally. This CL
    > enforces the supported range in VaapiWrapper::CreateContext().
    > This also introduces a feature,
    > VaapiEnforceVideoMinMaxResolution, to disable this check for
    > testing.
    >
    > Bug: b:171041334
    > Test: video.Play.vp9_hw on atlas and cyan
    > Test: video_decode_accelerator_tests on atlas and cyan
    > Test: video_encode_accelerator_tests on atlas and cyan
    > Test: appr.tc/?vsc=h264&vrc=h264&debug=loopback on atlas and cyan
    > Change-Id: Ide589ee4d1456553e400a271cb8b3383b472b4d4
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549161
    > Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
    > Auto-Submit: Hirokazu Honda <hiroh@chromium.org>
    > Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
    > Reviewed-by: Miguel Casas <mcasas@chromium.org>
    > Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#832609}
    
    TBR=dalecurtis@chromium.org,mcasas@chromium.org,hiroh@chromium.org,andrescj@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: b:171041334,b:175509204,b:175515392
    Change-Id: I18e172dac47aae5949329b183373b59ee862c1d5
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589257Reviewed-by: default avatarHirokazu Honda <hiroh@chromium.org>
    Reviewed-by: default avatarDavid Staessens <dstaessens@chromium.org>
    Commit-Queue: David Staessens <dstaessens@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#836958}
    667dc36e
media_switches.h 12 KB