• Scott Violet's avatar
    Revert "Remove retired mac versions from blinkpy." · 66d8bd2b
    Scott Violet authored
    This reverts commit 0745b831.
    
    Reason for revert: We still have 10.10 bots on the waterfall. This breaks the Mac10.10 bot. See https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/56807 and the blink_python_tests . Sample error:
    
    [1690/1762] blinkpy.web_tests.servers.cli_wrapper_unittest.CliWrapperTest.test_main_server_error_after_start failed unexpectedly:
      Traceback (most recent call last):
        File "/b/s/w/ir/third_party/blink/tools/blinkpy/web_tests/servers/cli_wrapper_unittest.py", line 54, in test_main_server_error_after_start
          argv=[])
        File "/b/s/w/ir/third_party/blink/tools/blinkpy/web_tests/servers/cli_wrapper.py", line 87, in main
          port_obj = host.port_factory.get(options=options)
        File "/b/s/w/ir/third_party/blink/tools/blinkpy/web_tests/port/factory.py", line 91, in get
          self._host, port_name, options=options, **kwargs)
        File "/b/s/w/ir/third_party/blink/tools/blinkpy/web_tests/port/mac.py", line 71, in __init__
          assert self._version in self.SUPPORTED_VERSIONS
      AssertionError
    
    
    Original change's description:
    > Remove retired mac versions from blinkpy.
    > 
    > This cl removes blinkpy support for Mac10.10, Mac10.11, and Mac Retina.
    > blink web tests for these versions has been removed from waterfall.
    > 
    > Bug: 1077312, 1107003, 1114680
    > Change-Id: I819d0bf7316119b2f5bc127f6eda1deaba7e0cd9
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343548
    > Commit-Queue: Ilia Samsonov <isamsonov@google.com>
    > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#796476}
    
    TBR=wangxianzhu@chromium.org,isamsonov@google.com
    
    Change-Id: I196b5f27ab989ea18e0ebccf2164f578826b6a68
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1077312
    Bug: 1107003
    Bug: 1114680
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347326Reviewed-by: default avatarScott Violet <sky@chromium.org>
    Commit-Queue: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#796571}
    66d8bd2b
builders.json 3.94 KB