• Mikel Astiz's avatar
    Populate outgoing sync bookmark GUIDs · 670c9969
    Mikel Astiz authored
    The field gets populated only if the committing client is sure about
    the GUID being the authoritative one (consistent with the originator
    client item ID).
    
    Instead of introducing a new field for the originator item ID or a
    boolean representing whether the GUID is indeed authoritative/final,
    the existing field |client_tag_hash| is leveraged for this purpose,
    which was unpopulated for bookmarks prior to this patch.
    
    This is aligned with future plans to actually introduce a client tag
    for bookmarks, just like for the rest of sync datatypes.
    
    Bug: 978430
    Change-Id: I66dd9d46d2d23aa86b0c9d88dcd6aed4a896c834
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981610
    Commit-Queue: Mikel Astiz <mastiz@chromium.org>
    Reviewed-by: default avatarMohamed Amir Yosef <mamir@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#732335}
    670c9969
bookmark_remote_updates_handler_unittest.cc 53.5 KB