• Tommy Steimel's avatar
    Revert "Show Variations info in cmd format in about:version." · 6788e47a
    Tommy Steimel authored
    This reverts commit 5b240cfb.
    
    Reason for revert: breaking tests on iOS bot:
    
    https://ci.chromium.org/buildbot/chromium.mac/ios-simulator-full-configs/2677
    
    VisibleURLTestCase/testDoubleForwardNavigationToWebUIPage:
    [0201/113634.854499:FATAL:template_expressions.cc(97)] Check failed: value != replacements.end(). $i18n replacement key "variations_cmd_name" not found
    
    Original change's description:
    > Show Variations info in cmd format in about:version.
    > 
    > When navigating to about:version/?show-variations-cmd an additional section
    > will appear showing complete set of client's variations in the command line
    > formatting that can be used to reproduce the same exact state of variations.
    > The displayed info contains all the trials including not activated ones
    > marked by '*' along with the corresponding group assignment.
    > It will also contain enabled and disabled features where the ones that should
    > use the default value will be marked with '*'(e.g. expired trials).
    > Trials that are unforcable through command line will be shown but warning will
    > be shown when processing the command line input with unforcable trial.
    > This CL doesn't cover iOS.
    > 
    > As the displayed text is huge I also changed the width of the text in the
    > about:version page (not mobile) to be 60% of the page with a minimum of 800px
    > as it used to be.
    > 
    > Bug: 694675
    > TEST=unit test, manual testing
    > 1. run chrome with --fake-variations-channel=beta
    > 2. copying command line input from about:version/?show-variations-cmd
    > 3. run chrome without channel but with command line input copied in step 2.
    > 4. confirm about:version/?show-variations-cmd page shows the same info
    > 
    > Change-Id: Ie73174bd5bd1a02baa75cd3294fd36cf63b3c923
    > Reviewed-on: https://chromium-review.googlesource.com/865286
    > Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
    > Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
    > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#533742}
    
    TBR=asvitkine@chromium.org,gayane@chromium.org,dschuyler@chromium.org
    
    Change-Id: I81dd667cfde45c209eed9889c0785fc0587b123d
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 694675
    Reviewed-on: https://chromium-review.googlesource.com/898405Reviewed-by: default avatarTommy Steimel <steimel@chromium.org>
    Commit-Queue: Tommy Steimel <steimel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#533844}
    6788e47a
about_version.js 2.48 KB