- 01 Feb, 2018 40 commits
-
-
Tommy Steimel authored
This reverts commit 5b240cfb. Reason for revert: breaking tests on iOS bot: https://ci.chromium.org/buildbot/chromium.mac/ios-simulator-full-configs/2677 VisibleURLTestCase/testDoubleForwardNavigationToWebUIPage: [0201/113634.854499:FATAL:template_expressions.cc(97)] Check failed: value != replacements.end(). $i18n replacement key "variations_cmd_name" not found Original change's description: > Show Variations info in cmd format in about:version. > > When navigating to about:version/?show-variations-cmd an additional section > will appear showing complete set of client's variations in the command line > formatting that can be used to reproduce the same exact state of variations. > The displayed info contains all the trials including not activated ones > marked by '*' along with the corresponding group assignment. > It will also contain enabled and disabled features where the ones that should > use the default value will be marked with '*'(e.g. expired trials). > Trials that are unforcable through command line will be shown but warning will > be shown when processing the command line input with unforcable trial. > This CL doesn't cover iOS. > > As the displayed text is huge I also changed the width of the text in the > about:version page (not mobile) to be 60% of the page with a minimum of 800px > as it used to be. > > Bug: 694675 > TEST=unit test, manual testing > 1. run chrome with --fake-variations-channel=beta > 2. copying command line input from about:version/?show-variations-cmd > 3. run chrome without channel but with command line input copied in step 2. > 4. confirm about:version/?show-variations-cmd page shows the same info > > Change-Id: Ie73174bd5bd1a02baa75cd3294fd36cf63b3c923 > Reviewed-on: https://chromium-review.googlesource.com/865286 > Commit-Queue: Gayane Petrosyan <gayane@chromium.org> > Reviewed-by: Dave Schuyler <dschuyler@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533742} TBR=asvitkine@chromium.org,gayane@chromium.org,dschuyler@chromium.org Change-Id: I81dd667cfde45c209eed9889c0785fc0587b123d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 694675 Reviewed-on: https://chromium-review.googlesource.com/898405Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#533844}
-
Weidong Guo authored
Changes: Make the source view focused when the context menu for the view is opened. BUG=795994 TEST=AppListViewFocusTest.ItemFocusedWhenContextMenuOpened Change-Id: Ibcc7fd5a054793d1a0abfe40fe0d04c07f00e3d3 Reviewed-on: https://chromium-review.googlesource.com/896633 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#533843}
-
Michael Hablich authored
This reverts commit 1a753dfc. Reason for revert: Not the culprit Original change's description: > Revert "Update V8 to version 6.6.133." > > This reverts commit e0a03346. > > Reason for revert: compile failed on linux cfi: > > https://ci.chromium.org/buildbot/chromium.memory/Linux%20CFI/5604 > > [19881/22628] ACTION //tools/v8_context_snapshot:generate_v8_context_snapshot(//build/toolchain/linux:clang_x64) > FAILED: v8_context_snapshot.bin > python ../../build/gn_run_binary.py ./v8_context_snapshot_generator --output_file=v8_context_snapshot.bin > ../../base/no_destructor.h:64:21: runtime error: control flow integrity check for type 'gin::(anonymous namespace)::PageAllocator' failed during cast to unrelated type (vtable address 0x000000000000) > 0x000000000000: note: invalid vtable > <memory cannot be printed> > ./v8_context_snapshot_generator failed with exit code 1 > > Original change's description: > > Update V8 to version 6.6.133. > > > > Summary of changes available at: > > https://chromium.googlesource.com/v8/v8/+log/2fc50dd0..595a0288 > > > > Please follow these instructions for assigning/CC'ing issues: > > https://github.com/v8/v8/wiki/Triaging%20issues > > > > Please close rolling in case of a roll revert: > > https://v8-roll.appspot.com/ > > This only works with a Google account. > > > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > > > > TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org > > > > Change-Id: I5634398067826ef46a257e578af8958d333caf57 > > Reviewed-on: https://chromium-review.googlesource.com/897748 > > Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> > > Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#533775} > > TBR=v8-autoroll@chromium.org,machenbach@chromium.org,hablich@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org > > Change-Id: Ie2f24c3d0d5ad77e34b60ec6373ae270ddd6b0e8 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > Reviewed-on: https://chromium-review.googlesource.com/898163 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533823} TBR=v8-autoroll@chromium.org,machenbach@chromium.org,hablich@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org,steimel@chromium.org Change-Id: I558d2ab3870824849e68a2758838c4d4b2854e9d No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/898404Reviewed-by:
Michael Hablich <hablich@chromium.org> Reviewed-by:
-
Daniel Bratell authored
In jumbo builds many cc files compile in the same translation unit and then they share the same anonymous namespace. Having the functions with the same names will then result in compilation failures. In preparation for jumbo in chrome/browser, this patch renames a number of helper functions in chrome/browser/android/history_report to have unique names. An alternative would have been to make the functions static private functions inside the classes. Bug: 746957 Change-Id: I2df32461d170c5411418cab78abc3020dc0a8109 Reviewed-on: https://chromium-review.googlesource.com/897536Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#533841}
-
Tommy Steimel authored
This reverts commit 1cc19640. Reason for revert: compile failed on linux cfi: https://ci.chromium.org/buildbot/chromium.memory/Linux%20CFI/5604 [19881/22628] ACTION //tools/v8_context_snapshot:generate_v8_context_snapshot(//build/toolchain/linux:clang_x64) FAILED: v8_context_snapshot.bin python ../../build/gn_run_binary.py ./v8_context_snapshot_generator --output_file=v8_context_snapshot.bin ../../base/no_destructor.h:64:21: runtime error: control flow integrity check for type 'gin::(anonymous namespace)::PageAllocator' failed during cast to unrelated type (vtable address 0x000000000000) 0x000000000000: note: invalid vtable <memory cannot be printed> ./v8_context_snapshot_generator failed with exit code 1 Original change's description: > [gin] Implement v8::Platform::GetPageAllocator. > > - Implements a v8::PageAllocator in terms of base page allocator functions. > This will cause V8 to use Chromium's page allocator and address space > randomization. > > Bug: chromium:756050 > Change-Id: Id076e599e7d5f09eddc78888245fc6bf879b1236 > Reviewed-on: https://chromium-review.googlesource.com/896959 > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533782} TBR=bbudge@chromium.org,jbroman@chromium.org,haraken@chromium.org Change-Id: I220fe81ce429bf62f29a431187b8407c9740fc93 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:756050 Reviewed-on: https://chromium-review.googlesource.com/898362Reviewed-by:
-
Daniel Bratell authored
chrome/browser/android/cdm/media_drm_credential_manager.cc sent a g_browser_process->system_request_context() into a Bind call without using any ref counting macros. That is prohibited by the bind system but the code got away with it when the pointer was just forward declared so that Bind didn't know that it was a ref counted type. In jumbo builds the compiler knew more about the return type of g_browser_process->system_request_context() and failed to compile because of static_asserts in bind_internal.h. This patch adds base::Unretained() since that seems to be the right macro for this type of value. Bug: 746957 Change-Id: Idfc3ad9bd6708dbc5ef4f295397d05d961595b4a Reviewed-on: https://chromium-review.googlesource.com/897535Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#533839}
-
Karan Bhatia authored
This CL introduces the "hosts" key within the "declarative_net_request" manifest key. It is used to specify a list of match patterns. These match patterns will then be used by DNR to evaluate whether an extension has access to a particular request for the purpose of DNR. The parsing of host permissions within PermissionsParser is refactored and a new static utility method called ParseHostPermissions is introduced on the class to parse a list of match patterns. In subsequent CLs, the concept of hosts for DNR will be introduced in the PermissionsSet class and DNR will start checking these host permissions. BUG=777714, 696822 Doc=go/dnr-hosts Change-Id: Iee31b634ce5e45c5685ad4264219cb79b70070aa Reviewed-on: https://chromium-review.googlesource.com/888321 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533838}
-
Nate Chapin authored
This removes the last callers of StyleInvalidImage, so delete it. Bug: 804409 Change-Id: I0b7cbfd9c764c7255ad7b22212add3c125902b39 Reviewed-on: https://chromium-review.googlesource.com/879409Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#533837}
-
James Forshaw authored
This CL changes the build behavior for debug builds to always pass the /DYNAMICBASE flag which enables ASLR relocation of executables. The removal of /DYNAMICBASE from debug builds interacts badly with the sandbox and a new feature to add AppContainer support as the OS enables an option to force ASLR regardless of whether an executable has been built with /DYNAMICBASE or not. The rationale for disabling ASLR was to simplify debugging in the WinDBG debugger due to the name conflict between chrome.exe and chrome.dll. However due to changes in the underlying debug engine as well as chrome_elf.dll loading before chrome.dll this no longer makes it useful. Bug: 807267 Change-Id: I651d2b1aa2eb970cc02e7063b5467144c69d23be Reviewed-on: https://chromium-review.googlesource.com/897623Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#533836}
-
David Tseng authored
This adds active descendant to a few output rules that should have it. Note that explicitly including the active descendant in these rules makes it possible to continue to see the entire output rule as a whole. This makes it possible to provide more intelligent output based on @message_strings, if desired. Bug: 781840 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia3f8bb0e6613d55e080be7b6eccfbdf0ee35033e Reviewed-on: https://chromium-review.googlesource.com/898023Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#533835}
-
Meredith Lane authored
Adds the IDL code and accessor methods into ComputedAccessibleNode for the intersection of properties between AccessibleNode and AXStringAttribute. These accessors will return null strings to the window in a few cases: - when the AXNode for a given matching AXID is not in the tree, - when the string property has not been set. Currently, the accessors are rudimentary and require an enum translation, although this may change in future in favour of an individual hard coded method on the AomContentAXTree. BUG=792783 Change-Id: Icd9cac2cb8486d549932f400b0aeeae569a1f712 Reviewed-on: https://chromium-review.googlesource.com/883863 Commit-Queue: Meredith Lane <meredithl@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
https://chromium.googlesource.com/angle/angle.git/+log/9dbaeba89424..5c5d7deef28d $ git log 9dbaeba89..5c5d7deef --date=short --no-merges --format='%ad %ae %s' 2018-02-01 lucferron Remove test restrictions on dEQP gles3 texture.compressedtexsubimage* tests Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ibc4a50753d2891146725eb3c593674974af374fa Reviewed-on: https://chromium-review.googlesource.com/898098Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533833}
-
Dmitry Gozman authored
Bug: none Change-Id: I2d5b7c11a77d990e9b6c243a9fa335f970f7358f Reviewed-on: https://chromium-review.googlesource.com/898073Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533832}
-
Ulan Degenbaev authored
This reverts commit 0c264842. The new iframe test is fragile and is not properly waiting for the iframe onload event. Since the problem is in the test, relanding without the test for now to unblock other changes. Original change's description: > Capture all DOM nodes reachable from V8 in heap snapshot. > > This patch uses the new EmbedderGraph API to provide the heap snapshot > generator with all DOM nodes and references reachable from V8. > > Bug: 749490 > Change-Id: I26750a8b80dab4f88508e504b431d976a598c6c3 > Reviewed-on: https://chromium-review.googlesource.com/890260 > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> Change-Id: I1d736a74b2f39443c490aecbfe7f6d305a669711 TBR=haraken@chromium.org,alph@chromium.org Change-Id: I1d736a74b2f39443c490aecbfe7f6d305a669711 Reviewed-on: https://chromium-review.googlesource.com/897644 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#533831}
-
Peter Wen authored
ui_java resources are intended to be used later. Other resources were no longer being used. Bug: 806060 Change-Id: Ifde5a469adc0453e65483d6988dcbb3dc4a1a876 Reviewed-on: https://chromium-review.googlesource.com/896405 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#533830}
-
Jungshik Shin authored
By default, ICU tries to load data items (e.g. brkitr/char.brk) from individual files before trying the common data. Because all the ICU data Chrome needs is included in the common ICU data file that is memory mapped in InitializeICU(), trying to load from the disk just wastes cycles (It fails inside sandbox. So does it in the browser process because there's no file with separate ICU data items). Bug: 805694 Test: None Change-Id: I3c633dd9d3bffc2cfb714eb4ec36c17a4ab9fd46 Reviewed-on: https://chromium-review.googlesource.com/890176Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533829}
-
Guido Urdaneta authored
In screen capture it is possible to have multiple sessions associated to the same device in the same renderer process. Prior to this CL, MSM::StopStreamDevice() received only the device ID, which sometimes resulted in the wrong screen-capture tracks being stopped on the renderer side. This CL adds the session ID to the StopStreamDevice() so that only the correct track is stopped. Bug: 788400 Change-Id: If759af86fa9819e4c3574b2bc840ad45c3c924b7 Reviewed-on: https://chromium-review.googlesource.com/892859Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#533828}
-
John Abd-El-Malek authored
Reduce network::URLLoader dependencies to net::URLRequestContextGetter and network::mojom::NetworkServiceClient. This makes it easier to reuse on iOS for servicing network::mojom::URLLoader requests. This also allows the removal of the URLLoader lifetime management in NetworkContext, and instead we can use the lifetime management in net::URLRequestContextGetter. Lastly, move url_request_context_owner to services/network as it's not really a client library. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I5dfeefd8b29f37ea24ac26167ccb064b6af42afc Reviewed-on: https://chromium-review.googlesource.com/897462 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#533827}
-
proberge authored
In https://bugs.chromium.org/p/chromium/issues/detail?id=791929 we provided a quick fix for extensions which were erroneously marked as corrupted by the content verifier. The fix involved checking for empty paths. However, extensions could also make requests to one of their folders and trigger the content verifier. Bug: 792538 Change-Id: Ie5c62e6e54481bcd4670e8b19cc5608268014494 Reviewed-on: https://chromium-review.googlesource.com/894162 Commit-Queue: proberge <proberge@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#533826}
-
Rune Lillesveen authored
A single anonymous flex/grid item should just contain a contiguous sequence of text runs. TEST=external/wpt/css/css-flexbox/anonymous-flex-item-004.html Bug: 807497 Change-Id: If995a5ac107210083fd13de9c6983b91b4ef3fa3 Reviewed-on: https://chromium-review.googlesource.com/895844 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#533825}
-
Danyao Wang authored
This reverts commit 091e44cb. Reason for revert: Suspect that this broke the tree: https://logs.chromium.org/v/?s=chrome%2Fbb%2Finternal.bling.main%2Fiphone11-device-x64%2F2513%2F%2B%2Frecipes%2Fsteps%2Fios_web_unittests__iPhone_7_iOS_11.2.1__on_iOS-11.2.1%2F0%2Fstdout Original change's description: > [Nav Experiment] Fix form repost detection in WKBasedNavigationManager. > > This CL moves form repost detection for WKBasedNavigationManager to > in |webView:decidePolicyForNavigationAction|, where WKWebView gives a > clear signal about form reposting (WKNavigationTypeFormResubmitted). > This allows simplifying reload for WKBasedNavigationManager to directly > delegating to [WKWebView reload]. > > FormsTestCase now pass with WKBasedNavigationManager. > > Bug: 807428,705020 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: Ia35978c42b21405a3749d1764a0485cde9c805d2 > Reviewed-on: https://chromium-review.googlesource.com/894892 > Commit-Queue: Danyao Wang <danyao@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533692} TBR=eugenebut@chromium.org,danyao@chromium.org Change-Id: I1db11102b3df8a8c0a37610e36ca229343367c8a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 807428, 705020 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/898164Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#533824}
-
Tommy Steimel authored
This reverts commit e0a03346. Reason for revert: compile failed on linux cfi: https://ci.chromium.org/buildbot/chromium.memory/Linux%20CFI/5604 [19881/22628] ACTION //tools/v8_context_snapshot:generate_v8_context_snapshot(//build/toolchain/linux:clang_x64) FAILED: v8_context_snapshot.bin python ../../build/gn_run_binary.py ./v8_context_snapshot_generator --output_file=v8_context_snapshot.bin ../../base/no_destructor.h:64:21: runtime error: control flow integrity check for type 'gin::(anonymous namespace)::PageAllocator' failed during cast to unrelated type (vtable address 0x000000000000) 0x000000000000: note: invalid vtable <memory cannot be printed> ./v8_context_snapshot_generator failed with exit code 1 Original change's description: > Update V8 to version 6.6.133. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/2fc50dd0..595a0288 > > Please follow these instructions for assigning/CC'ing issues: > https://github.com/v8/v8/wiki/Triaging%20issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org > > Change-Id: I5634398067826ef46a257e578af8958d333caf57 > Reviewed-on: https://chromium-review.googlesource.com/897748 > Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> > Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533775} TBR=v8-autoroll@chromium.org,machenbach@chromium.org,hablich@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ie2f24c3d0d5ad77e34b60ec6373ae270ddd6b0e8 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/898163Reviewed-by:
-
Daniel Park authored
Bug: 805479 Change-Id: Icf3110416b4f619f6854e46a685b39b4664cbef9 Reviewed-on: https://chromium-review.googlesource.com/897995Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Daniel Park <danielpark@chromium.org> Cr-Commit-Position: refs/heads/master@{#533822}
-
https://webrtc.googlesource.com/src.git/+log/28dbf9724281..bc3b7828139c $ git log 28dbf9724..bc3b78281 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I446c61c0e537dcde85a4585bd274c2684eb480fd Reviewed-on: https://chromium-review.googlesource.com/897986 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533821}
-
xlai authored
This is a partial revert of the big refactoring CL https://chromium-review.googlesource.com/c/chromium/src/+/864630. That CL made the creation of CanvasResourceProvider for canvas 2d earlier at the point of time when Canvas2DLayerBridge is created; this changed the code paths of some instances and should not belong to a refactoring CL that is not intended to change behavior. Bug: 806066 Change-Id: I00493338f6bda4a9ea17ee01db2dcab29223398c Reviewed-on: https://chromium-review.googlesource.com/896084Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Olivia Lai <xlai@chromium.org> Cr-Commit-Position: refs/heads/master@{#533820}
-
Dominic Mazzoni authored
AXTree now keeps track of reverse relationships automatically, so take advantage of that to expose reverse relationships for some attributes already exposed in the automation API. Also add two relation attributes that are supported by Blink but weren't added to automation yet: details, errorMessage. The new attributes are: detailsFor (reverse of details) errorMessageFor (reverse of errorMessage) controlledBy (reverse of controls) descriptionFor (reverse of describedBy) flowFrom (reverse of flowTo) labelFor (reverse of labelledBy) Bug: 757707 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I112c283c87274388fc9e7e725bcc126393133e39 TBR: michaelpg@chromium.org Reviewed-on: https://chromium-review.googlesource.com/837643 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#533819}
-
Toni Barzic authored
The API supports passing WifiProperties.Passphrase to setProperties, but that hasn't been documented - this fixes the documentation. BUG=none Change-Id: I1ab278f82cc61385d12faff32e7e66a9d44da57b Reviewed-on: https://chromium-review.googlesource.com/896867Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#533818}
-
Nico Weber authored
Bug: 177475 Change-Id: I7985f9356fcac3c4c2e05fc3cdda0b52d132c7c7 Reviewed-on: https://chromium-review.googlesource.com/896718 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533817}
-
Evan Stade authored
Porting this test to a world where the message center and notification blockers live out of the Chrome process would be difficult. The functionality under test is already covered by two ash unit tests: - SessionStateNotificationBlockerTest - InactiveUserNotificationBlockerTest Bug: 578868 Change-Id: Ibbbfc232bb3938eec1c84e6a6bd8bb4a5d028236 Reviewed-on: https://chromium-review.googlesource.com/897885Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Kevin Marshall authored
The parent/browser process can set these clone options to configure the capabilities which will be propagated to the newly launched child process. Bug: 750938 Change-Id: Ic4403c5e9c61e7ce226af22d0bcdb3f1362a95f4 Reviewed-on: https://chromium-review.googlesource.com/861283 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#533815}
-
Takumi Fujimoto authored
We will observe which display the Media Router dialog's initiator web contents are on, and hide the local screen sink for that display from the sink list. This is to prevent the user from launching a presentation window that covers the controlling window. It would be nicer if the WiredDisplayMRP were responsible for determining which sinks should be disabled. Unfortunately, there is no clean way for MRUI to notify WiredDisplayMRP which display the dialog is on. So it is done in MRUI instead. Also doing some cleanups in MRUI (base::MakeUnique to std::make_unique, base::Callback to base::RepeatingCallback). Bug: 800433 Change-Id: I0ec74758c485b89eee4f4417b7358922aa4f32a1 Reviewed-on: https://chromium-review.googlesource.com/830972 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#533814}
-
https://skia.googlesource.com/skia.git/+log/f8393c861975..7a13705e03b7 $ git log f8393c861..7a13705e0 --date=short --no-merges --format='%ad %ae %s' 2018-02-01 robertphillips Fix DDL unit tests 2018-02-01 rmistry Add recipe and bots for android-compile.skia.org 2018-02-01 borenet Fix skcms DEPS hash 2018-02-01 bsalomon Revert "Redefine the meaning of sample counts in GPU backend." 2018-02-01 ethannicholas updated .fp file headers 2018-02-01 reed add gpu impl for shadermaskfilter 2018-02-01 bsalomon Redefine the meaning of sample counts in GPU backend. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: Ida26dd048815bf86d32874001500bf05b9b0bdcc Reviewed-on: https://chromium-review.googlesource.com/898038 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533813}
-
Ken Buchanan authored
If an OOPIF detaches itself from the frame tree during layout, then its compositor is shutdown while in the midst of a BeginFrame, which causes a crash. This CL defers compositor shutdown, while allowing WebWidget closing to remain synchronous. Bug: 802392 Change-Id: Iefef08fca2e892409d12cc748ddaf257f3aa68e4 Reviewed-on: https://chromium-review.googlesource.com/890042 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#533812}
-
David Benjamin authored
TLS 1.3 includes a server_random-based anti-downgrade mechanism which gives it a stronger anti-downgrade store than prior versions of TLS. (This is essentially working around a bug in TLS 1.2 where it did not incorporate enough into the signature.) This is a few security improvement for Chrome users that should not disrupt the existing ecosystem. Unfortunately, we are aware that some Cisco middleboxes have buggy TLS 1.2 implementations that fail to generate their own server random value. Instead, they copy over another server's random value. This is invalid and does not comply with the TLS 1.2 specification. See https://www.ietf.org/mail-archive/web/tls/current/msg25168.html Due to deployment considerations, this feature cannot be enabled until TLS 1.3 is final. In preparation for that, this CL adds metrics to determine the prevalance of these and potentially other non-compliant middlebox products out there. Bug: boringssl:226 Change-Id: Ie1288fadf84ff6988c741ceef1465c25559a369a Reviewed-on: https://chromium-review.googlesource.com/891499Reviewed-by:
Steven Valdez <svaldez@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#533811}
-
https://chromium.googlesource.com/catapult.git/+log/76e0bf087745..d2080c565153 $ git log 76e0bf087..d2080c565 --date=short --no-merges --format='%ad %ae %s' 2018-01-31 eakuefner [Dashboard] Filter out memory stats in V8 tests Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I9696b147cfb92f85079e70ee79cf8514c452fd5e Reviewed-on: https://chromium-review.googlesource.com/897982Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533810}
-
Devlin Cronin authored
If the Context is invalidated before the object GCCallback is watching is collected, a fallback is run and the original callback (for garbage collection) is never triggered. There was a bug where we only properly disposed of GCCallback (thus preventing it from triggering after the context invalidated) if a non-null fallback was provided. Fix this, properly cleaning up the GCCallback even with a null fallback, and add unit tests to cover this case. Bug: 808032 Change-Id: I0e17dfcec7d796883bc1b59bf450c86d3e79ac99 Reviewed-on: https://chromium-review.googlesource.com/898071Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533809}
-
Saman Sami authored
If we have a new LocalSurfaceId, the parent is blocking on us. Even if there is no damage, submit a CompositorFrame to unblock the parent. Bug: 672962 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Id29b855d111db8ee461778461314099c0885c415 Reviewed-on: https://chromium-review.googlesource.com/892142Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#533808}
-
https://chromium.googlesource.com/angle/angle.git/+log/c0db9addeaeb..9dbaeba89424 $ git log c0db9adde..9dbaeba89 --date=short --no-merges --format='%ad %ae %s' 2018-02-01 lucferron Validation layer fixes for compressedtexsubimage* dEQP tests Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Idef8176d7037d9903eae88e118a84636b7cc8cf1 Reviewed-on: https://chromium-review.googlesource.com/898035Reviewed-by:
-
Erik Luo authored
Functions formatted in console populate their element asynchronously with their function name. This may result in the blue 'i' info note on the wrong side. Screenshot: https://imgur.com/a/qQUBb Bug: 807815 Change-Id: Idd4e0bcba4369a0572dc26f57f61e46302205cb1 Reviewed-on: https://chromium-review.googlesource.com/896640Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#533806}
-
chaopeng authored
This patch is preparing for the new implementation of Direct Manipulation API. In the patch, we move direct_manipulation.h|cc to ui/base/win, change related macros, includes and run git cl format. Bug: 647140 Change-Id: Ib3acccf84737ae6c25be27ad0d2776ab005c5fd3 Reviewed-on: https://chromium-review.googlesource.com/896704Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#533805}
-
