-
Tetsui Ohkubo authored
NotificationViewMDTest were reverted due to LSan failure in NotificationViewMD. This CL fixes the leak and restores NotificationViewMDTest. The leak was caused because we assumed a->RemoveChildView(b) would delete the b object, but it was not true. We should use DCHECK(a->Contains(b)); delete b; instead. Original CL: https://codereview.chromium.org/2966343002/ BUG=733948,739356 TEST= gn gen out/asan --args='is_asan=true is_lsan=true enable_nacl=false is_debug=false' && ASAN_OPTIONS="detect_leaks=1 symbolize=1 external_symbolizer_path=`pwd`/third_party/llvm-build/ Release+Asserts/bin/llvm-symbolizer" out/asan/message_center_unittests Change-Id: I81f1aefdab6fafa35fd00e69875b1aa426822c9e Reviewed-on: https://chromium-review.googlesource.com/564859Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#485591}
67cb9794