• Ryan's avatar
    Avoid risky casts with NSS PIN prompts · 6823c241
    Ryan authored
    Avoid risky casts between void* and object pointers
    by using the wincx method on the
    CryptoModuleBlockingPasswordDelegate. While safety
    was assured by virtue of being passed as a
    scoped_refptr<> to the appropriate base class,
    consistently use the wincx() method of the password
    delegate so that safety can be reasoned about from
    the callsite, rather than inferred from the type.
    
    BUG=none
    
    Change-Id: I120584dd5a62d1533689871f4a207f7205c6ada7
    Reviewed-on: https://chromium-review.googlesource.com/c/1309097Reviewed-by: default avatarDavid Benjamin <davidben@chromium.org>
    Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#604091}
    6823c241
client_cert_store_nss.cc 7.28 KB