• Justin Cohen's avatar
    Reland "[ios] Enable preload with slim-navigation-manager." · 6836cfc5
    Justin Cohen authored
    This reverts commit ceff1a21.
    
    Reason for revert: Fixed.
    
    Original change's description:
    > Revert "[ios] Enable preload with slim-navigation-manager."
    >
    > This reverts commit 101b5ae0.
    >
    > Reason for revert: Needs some more work, some last minute
    > refactoring introduced some crashes.
    >
    > Original change's description:
    > > [ios] Enable preload with slim-navigation-manager.
    > >
    > > Previously, preload required CopyStateFromAndPrune and
    > > CanPruneAllButLastCommittedItem within NavigationManager, but those
    > > are not supported with SlimNav. Here, preload is implemented by
    > > creating a preload WebState with navigation history by restoring the
    > > current WebState.
    > >
    > > The performance of this implementation depends on Slim
    > > Navigation Manager's session restoration performance which can be
    > > measured with existing kRestoreNavigationTime metric.
    > >
    > > Original implementation of this CL was written by eugenebut@,
    > > simply updated in this resurrected CL.
    > >
    > > Bug: 834116
    > > Change-Id: I86c9ecf7e3ed213ebaeddce6264dff3bbb8a8c94
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815702
    > > Commit-Queue: Justin Cohen <justincohen@chromium.org>
    > > Reviewed-by: Rohit Rao <rohitrao@chromium.org>
    > > Reviewed-by: Eugene But <eugenebut@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#701228}
    >
    > TBR=rohitrao@chromium.org,justincohen@chromium.org,eugenebut@chromium.org,gambard@chromium.org
    >
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    >
    > Bug: 834116
    > Change-Id: I16beb96bc2d1eab9a9c36a8e03728fd3cc23f035
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833743
    > Reviewed-by: Justin Cohen <justincohen@chromium.org>
    > Commit-Queue: Justin Cohen <justincohen@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#701746}
    
    Change-Id: I52889208ed3a84c08c66742e72b524adce0560af
    Bug: 834116
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833706Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
    Reviewed-by: default avatarGauthier Ambard <gambard@chromium.org>
    Reviewed-by: default avatarRohit Rao <rohitrao@chromium.org>
    Auto-Submit: Justin Cohen <justincohen@chromium.org>
    Commit-Queue: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#702004}
    6836cfc5
prerender_service.mm 4.15 KB