• David Black's avatar
    Fix crash in Assistant response processing. · 6848457e
    David Black authored
    The chain of ownership between AssistantResponseProcessor and UI
    elements that were being processed was overly complicated. Previously,
    it was possible for callbacks to fire when the underlying UI element
    had already been destroyed.
    
    Now, we refactor processing logic so that processors are bound to the
    response/element that they are processing. As such, lifecycle
    complications are drastically simplified.
    
    Bug: b:119674543
    Change-Id: I04a08f29ffaf0178d409c7bc0e5d84292993d1ae
    Reviewed-on: https://chromium-review.googlesource.com/c/1350961
    Commit-Queue: David Black <dmblack@google.com>
    Reviewed-by: default avatarXiaohui Chen <xiaohuic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#611997}
    6848457e
assistant_response.h 3.8 KB