GitLab

1) Before this CL, some ModelTypeControllers called IsWebSignout() in
their GetPreconditionState() implementation to make sure the data type
was stopped upon web sign-out. This is no longer needed following the
StopSyncInPausedState launch (crbug.com/906995), so this CL removes such
checks.
If GetPreconditionState() makes no other checks, the controller also no
longer needs to observe the SyncService. Note this isn't true for
controllers that check for persistent auth errors, since that concept is
more general than web sign-out. For those, only TODOs/includes are
removed.

2) The CL also addresses one IsWebSignout() TODO in PersonalDataManager.
Contrary to what the TODO implies, just removing the call isn't enough.
IsSyncFeatureEnabled() returns true in the sync-paused state, so the
check for TransportState::PAUSED must be moved up.

3) Finally, the CL updates the last TODO pointing to crbug.com/906995
to point to a newly filed bug. This concludes the post-launch cleanup
for StopSyncInPausedState.

Bug: 1140447
Change-Id: I996a8871050f8f18e1509a5560ca0ccfc849f217
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505772Reviewed-by: sebsg <sebsg@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/master@{#836062}