• Adrienne Walker's avatar
    cc: Make paint_op_buffer_eq_fuzzer not binary compare · 68dd310e
    Adrienne Walker authored
    This test case has a DrawRecord in the middle of it.  There was some
    hope previously that because this fuzzer memset all the memory it
    was allocating, then all the unwritten memory could be consistent.
    However, because a bunch of other memory gets allocated when serializing
    then that memory can have garbage in the padding.  When simple ops
    memcpy as a part of serializing or deserializing, they bring along
    that garbage, which can cause binary differences.
    
    This was lucky that this has ever worked on Skia serialization, so
    remove the binary comparison and just use the logical comparison.
    
    Bug: 870647
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Ie20097c4df4953bb6503caff81ad811dc69acc63
    Reviewed-on: https://chromium-review.googlesource.com/1162746Reviewed-by: default avatarKhushal <khushalsagar@chromium.org>
    Commit-Queue: enne <enne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#581265}
    68dd310e
paint_op_buffer_eq_fuzzer.cc 5.51 KB